Repository navigation
Document error types for Janus 0.9 - #204
Merged
Merged
Conversation
0.9.x version of Janus can use new custom error types defined by Divvi Up, introduced in divviup/janus#4915. This commit adds documentation for those errors corresponding to the problem documents Janus constructs, and does a little bit of wordsmithing on existing error docs.
Contributor
Author
|
I do not think that implementing draft-ietf-ppm-dap-20 aggregate share handling will require new errors, because the existing "Aggregate Share ID Unrecognized" and "Aggregate Share Request Rejected" should do it. It's a little unfortunate that we have "Aggregation Job Deleted" and "Collection Job Deleted" but then "Aggregate Share ID Unrecognized" but so be it. |
divergentdave
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.9.x version of Janus can use new custom error types defined by Divvi Up, introduced in divviup/janus#4915. This commit adds documentation for those errors corresponding to the problem documents Janus constructs, and does a little bit of wordsmithing on existing error docs.